PSCE-243 #53
Closed
PSCE-243 #53
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
reviewed
Oct 5, 2023
actions/trestle-bot/action.yml
Outdated
|
|
||
| runs: | ||
| using: "docker" | ||
| image: "Dockerfile" |
There was a problem hiding this comment.
Is this a path? Would it be different now that the action file is not in the root of the directory?
Related: PSCE-243 Signed-off-by: Alex Flom <[email protected]>
12 tasks
jpower432
requested changes
Oct 10, 2023
- Consolidates multiple trestle-bot entrypoints within the published trestle-bot image. Related PSCE-243, PSCE-250 Signed-off-by: Alex Flom <[email protected]>
jpower432
reviewed
Oct 10, 2023
| @@ -81,7 +81,7 @@ outputs: | |||
|
|
|||
| runs: | |||
| using: "docker" | |||
| image: "Dockerfile" | |||
| image: "quay.io/continuouscompliance/trestlebot:latest" | |||
There was a problem hiding this comment.
If we point to the pre-built image, I would prefer we not point to latest. Pointing to latest means that older versions of the trestlebot action could be pointing to the newest image and breaking changes could make older version of the action unusable (i.e. inputs are expected, but not provided in the action.yml)
|
'twas cherry-picked. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.